Skip to content

docs(#6456): align SKILL.md bot-login refs with GraphQL-format constants - #6457

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/6456-fix-skill-bot-login-refs
Aug 27, 2026
Merged

docs(#6456): align SKILL.md bot-login refs with GraphQL-format constants#6457
rh-hemartin merged 1 commit into
mainfrom
agent/6456-fix-skill-bot-login-refs

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Context

PR #6206 fixed bot-login constants to use GraphQL-format logins, but the review agent's finding about stale SKILL.md references was not addressed before merge. This PR completes that cleanup.

Testing

  • Verified grep -c '\[bot\]' skills/nextwork/SKILL.md returns 0
  • Verified all three updated references now match the code constant fullsend-ai-review
  • Markdown link checker (make lint-md-links) passed with 0 errors

Closes #6456

Post-script verification

  • Branch is not main/master (agent/6456-fix-skill-bot-login-refs)
  • Secret scan passed (gitleaks — eeeab1a01ddfef5cdaf16424dcd21878cb557eaf..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

PR #6206 updated REVIEW_BOT_LOGIN in nextwork.py to use the
GraphQL-format login `fullsend-ai-review` (without `[bot]`
suffix). Three references in skills/nextwork/SKILL.md still
used the old REST-format `fullsend-ai-review[bot]`, creating
documentation drift. Remove the `[bot]` suffix from lines 55
(--resolve-threads), 88 (waiting_fix status), and 253
(bot_only field) to match the code constants.

Note: pre-commit could not run (sandbox network policy blocked
hook environment setup). Markdown link checker passed.

Closes #6456
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 21, 2026 19:28
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Aug 21, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 21, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:30 PM UTC · Completed 7:40 PM UTC

Commit: 8961ae0 · View workflow run →

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 21, 2026
@rh-hemartin
rh-hemartin added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 8266cbb Aug 27, 2026
54 of 55 checks passed
@rh-hemartin
rh-hemartin deleted the agent/6456-fix-skill-bot-login-refs branch August 27, 2026 08:25
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 27, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 8:27 AM UTC · Completed 8:39 AM UTC

Commit: 8961ae0 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $3.62

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #6457 — align SKILL.md bot-login refs with GraphQL-format constants

Timeline

This PR is the result of a full end-to-end automation loop that worked cleanly:

  1. PR fix(#6205): strip [bot] suffix from bot-login constants in nextwork.py #6206 (merged Aug 21) fixed bot-login constants in nextwork.py from REST format (fullsend-ai-review[bot]) to GraphQL format (fullsend-ai-review). The review agent (run 31738319224) correctly flagged a low-severity stale-identifier-reference noting that skills/nextwork/SKILL.md still used the old [bot] suffix in three places. The human reviewer approved without addressing it.

  2. Retro agent filed issue #6456 ~20 minutes after PR fix(#6205): strip [bot] suffix from bot-login constants in nextwork.py #6206 merged, with exact file paths, line numbers, and validation criteria.

  3. Triage agent (run 32517670171) confirmed the issue in ~4 minutes.

  4. Code agent (run 32518137236) fixed all 3 references correctly on the first attempt in ~6.5 minutes. Pre-commit hooks failed in sandbox due to network policy, but the harness's authoritative post-script pre-commit run succeeded.

  5. Review agent (run 32518680566) flagged only a medium-severity protected-path finding for skills/ — appropriate for the directory.

  6. Human reviewer (rh-hemartin) approved and merged on Aug 27, ~6 days after PR creation.

What went well

Existing issues with new evidence

Agents repo

All agents resolved from fullsend-ai/agents at commit 12f5d88b5d8cc4ab12ba1c6332c6c512deaa0b0e.

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Agent PR ready for human review requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update SKILL.md bot-login references to match GraphQL-format constants from PR #6206

1 participant